[scroll-animations-1] Define named view timeline phases and their usage. #7044 - #7710
Conversation
da8e073 to
829f280
Compare
829f280 to
77d04a1
Compare
| [Exposed=Window] | ||
| interface AnimationTimeline { | ||
| readonly attribute double? currentTime; | ||
| CSSNumericValue? getCurrentTime(optional CSSOMString rangeName); |
There was a problem hiding this comment.
Still using spaces, for some reason?
There was a problem hiding this comment.
So usually when I write preformatted code I indent my source with tabs and indent the preformatted code with spaces. Are you saying that Bikeshed converts tabs to spaces in the output?
There was a problem hiding this comment.
Yes. It'll preserve spaces if you use them, but for pre it changes tabs into 4 spaces.
There was a problem hiding this comment.
Ok, I'll do that in a separate commit for the whole file maybe. Since the rest of the IDL also uses 2-space indents here.
c7369b5 to
ba56688
Compare
| The CSS ''@keyframes'' rule is extended thus: | ||
|
|
||
| <pre class="prod"> | ||
| <<keyframe-selector>> = from | to | <<percentage>> | <<timeline-range-name>> <<percentage>> |
There was a problem hiding this comment.
Should these animation property changes go in the css-animations spec?
There was a problem hiding this comment.
Eventually, yes. Right now CSS Animations 2 is only an ED and it's not clear what the plan is for FPWD.
| * the [=end=] [=border edge=] of the element’s [=principal box=] | ||
| coincides with the [=end=] edge of its [=view progress visibility range=]. | ||
|
|
||
| <dt><dfn>entry</dfn> |
There was a problem hiding this comment.
Should it? Kinda feels like phase names make more sense as nouns than verbs, but I'm open to debating it. Marked as an issue for now.
| Represents the range during which the [=principal box=] | ||
| is either fully contained by, or fully covers, | ||
| its [=view progress visibility range=] within the [=scrollport=]. | ||
| * 0% progress represents the earlier position at which: |
There was a problem hiding this comment.
Similar remark to the one above about the “View Progress Visibility Range” (vpvr) – it depends on how you look at it when naming the edges.
Maybe split this up differently so it talks about subjects smaller/larger then the possible area?
- For subjects whose size is smaller than the vpvr:
- 0% progress = the end border edge of the element’s principal box coinciding with the end edge of the vpvr
- 100% progress = the start border edge of the element’s principal box coinciding with the start edge of the vpvr
- For subjects whose size is larger than the vpvr:
- 0% progress = the start border edge of the element’s principal box coinciding with the start edge of the
- 100% progress = the end border edge of the element’s principal box coinciding with the end edge of the
There was a problem hiding this comment.
Similar remark to the one above about the “View Progress Visibility Range” (vpvr) – it depends on how you look at it when naming the edges.
Edges are named according to the writing mode, this is already defined at the bottom of the section.
Maybe split this up differently so it talks about subjects smaller/larger then the possible area?
Sure, could do that. Maybe in a follow-up commit? It does mess with parallel construction a bit and then have to pick which condition handles the "equal to" situation...
| * 100% is equivalent to 100% of the ''animation-timeline-range/cover'' range. | ||
| </dl> | ||
|
|
||
| ISSUE: Insert diagrams. |
There was a problem hiding this comment.
That would be super helpful!
ba56688 to
c9e4be5
Compare
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
c9e4be5 to
a21abcc
Compare
Addresses remaining points in #7044 (comment)