chore: Move Linux build and client dependencies in flet.utils to further simplify CI workflow#6383
Open
ndonkoHenri wants to merge 12 commits intorelease/v0.85.0from
Open
chore: Move Linux build and client dependencies in flet.utils to further simplify CI workflow#6383ndonkoHenri wants to merge 12 commits intorelease/v0.85.0from
flet.utils to further simplify CI workflow#6383ndonkoHenri wants to merge 12 commits intorelease/v0.85.0from
Conversation
Deploying flet-website-v2 with
|
| Latest commit: |
e06ae1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5fbc5653.flet-website-v2.pages.dev |
| Branch Preview URL: | https://linux-deps-as-util.flet-website-v2.pages.dev |
Deploying flet-examples with
|
| Latest commit: |
e06ae1a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef10bccb.flet-examples.pages.dev |
| Branch Preview URL: | https://linux-deps-as-util.flet-examples.pages.dev |
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes Linux apt dependency lists into the Python flet.utils package and updates CI/docs workflows to consume those canonical lists, reducing duplication and simplifying future maintenance of dependency sets.
Changes:
- Added
flet.utils.linux_depswith canonical Linux build/client apt dependency sets, and re-exported them viaflet.utils. - Updated CI/workflow YAML and publish docs to install Linux deps by querying
flet.utils.*_dependencies_aptinstead of duplicating package lists. - Improved version-related error logging to write to
stderr, and extended the build-test workflow with a newpackjob.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
sdk/python/packages/flet/src/flet/version.py |
Routes version discovery/parsing errors to stderr. |
sdk/python/packages/flet/src/flet/utils/linux_deps.py |
Introduces canonical Linux apt dependency tuples + space-joined strings for workflows. |
sdk/python/packages/flet/src/flet/utils/__init__.py |
Re-exports Linux dependency constants via flet.utils. |
sdk/python/packages/flet/docs/publish/index.md |
Updates workflow example to consume flet.utils.linux_build_dependencies_apt. |
.github/workflows/flet-build-test.yml |
Uses canonical Linux deps, adds version patching, fixes path filters, and adds a new pack job. |
.github/workflows/ci.yml |
Uses canonical Linux client deps for Flutter Linux client build step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Re-target this branch to release/v0.85.0 and add changelog record. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening due to accidental close of #6357
Summary by Sourcery
Centralize Linux build and client dependency definitions in the Python SDK and extend CI to build and pack a desktop test app across platforms.
New Features:
flet packwith configurable extra arguments.flet.utilsfor reuse in CI and documentation.Enhancements:
flet.utilsinstead of hardcoding apt packages.CI:
flet buildandflet packvia workflow_dispatch inputs.Documentation:
flet.utilshelpers instead of an inline apt package list.