fix: use TOP for MSSQL schema queries - #2495
Merged
Merged
Conversation
Gold Data ReportNotes
Commit Information
Summary
DetailsGold Data Metrics
|
Spark 3.5.9 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Spark 4.2.0 Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff--- before.txt 2026-08-24 16:48:26.391866682 +0000
+++ after.txt 2026-08-24 16:48:26.794865637 +0000
@@ -1893,0 +1894 @@
+pyspark/sql/tests/connect/test_parity_functions.py::FunctionsParityTests::test_make_timestampFailed Tests(truncated) |
Ibis Test ReportCommit Information
Test Summary
Test DetailsError CountsPassed Tests Diff(empty) Failed Tests |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #2495 +/- ##
==========================================
- Coverage 78.43% 77.11% -1.33%
==========================================
Files 966 966
Lines 194216 194216
==========================================
- Hits 152326 149762 -2564
- Misses 41890 44454 +2564
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
ErikBPF
force-pushed
the
fix/mssql-schema-inference
branch
from
August 24, 2026 17:36
4f63f38 to
574b5dd
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates JDBC schema inference to use SQL Server-compatible syntax while preserving existing behavior elsewhere.
Changes:
- Uses
SELECT TOP 0for MSSQL schema queries. - Adds tests for both
queryanddbtableoptions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
python/pysail/spark/datasource/jdbc.py |
Selects schema-query syntax based on the JDBC protocol. |
python/pysail/tests/test_jdbc.py |
Verifies MSSQL schema queries use TOP 0. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
linhr
reviewed
Aug 25, 2026
Fixes lakehq#2449 [catalog tests]
ErikBPF
force-pushed
the
fix/mssql-schema-inference
branch
from
August 25, 2026 10:38
574b5dd to
b57bf86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
SELECT TOP 0for SQL Server schema inferenceLIMIT 0for other JDBC sourcesqueryanddbtableoptions in default unit CIFixes #2449 — Read from SQL Server fails with syntax error
Testing
.venvs/default/bin/pytest -q python/pysail/tests/test_jdbc.py— 2 passedhatch fmt --checkThe PostgreSQL testcontainer suite needs Docker and could not run locally.