new_audit: third-party cookies - #15632
Merged
Merged
Conversation
adamraine
marked this pull request as ready for review
November 28, 2023 20:04
adamraine
force-pushed
the
3p-cookies
branch
from
November 28, 2023 20:44
888606a to
a62a9a1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
connorjclark
reviewed
Dec 7, 2023
| displayValue: '1 cookie found', | ||
| details: { | ||
| items: [ | ||
| {name: 'Foo', url: /^http:\/\/\[::1\]:10503\/dobetterweb\/empty_module\.js/}, |
Collaborator
There was a problem hiding this comment.
we should make a literalToRegexStartsWith('https://.....') ....
Contributor
Author
There was a problem hiding this comment.
new RegExp will escape all of the / for us but not the [. Eh too much thinking
Collaborator
There was a problem hiding this comment.
connorjclark
reviewed
Dec 7, 2023
| "headings": [], | ||
| "items": [] | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
should we update artifacts to populate this?
Contributor
Author
There was a problem hiding this comment.
Done, bit of noise in the sample changes but not too bad
Contributor
Author
There was a problem hiding this comment.
Update: I reverted this change because we will need to regen the DT log as well to prevent some subtle errors. I think the smoke test is sufficient until we do full artifacts regen.
connorjclark
approved these changes
Dec 7, 2023
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed internally on email chain. Wasn't too much work to create a prototype so here it is.
Technically we already surface these issues via the generic inspector issues audit alongside all the other cookie issues. However, specific information about each issue is missing and the call to action is just opening the issues panel for more info.
This audit will make 3PCD issues much more visible with a direct link to better documentation.