docs(configuration): update some wording of the "extends" property - #11488
Merged
Conversation
From my understanding of this documentation, there is a little bit more clarity which could be offered by different wording.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
patrickhulce
approved these changes
Sep 29, 2020
Collaborator
There was a problem hiding this comment.
thanks @DanArthurGallagher!
Collaborator
|
@DanArthurGallagher interested in signing the CLA and marking this as ready for review? :) |
Contributor
Author
|
@patrickhulce I will try to get that done this evening! |
Reflect the current state, not a decision. Co-authored-by: Patrick Hulce <patrick.hulce@gmail.com>
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
danieleloscozzese
marked this pull request as ready for review
October 5, 2020 20:51
danieleloscozzese
requested review from
connorjclark
and removed request for
a team
October 5, 2020 20:51
Collaborator
|
thanks @DanArthurGallagher 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
38B1
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From my understanding of this documentation, there is a little bit more clarity which could be offered by different wording.
Summary
This change tweaks the wording and the type definition around the
extendsproperty of the configuration to explain exactly which values are allowed.I feel that this could be useful since I am currently investigating some issues in a deployment of lighthouse and it was not particularly clear to me if our extension was valid or not at a glance.
Related Issues/PRs
I based this on some information I saw in #7344, including a response on that issue.
There is also the (type definition)[/types/config.d.ts]. I'm trying to find the code handling this to see if any other string does have a real value or not.