core: add unsupported css properties to non-composited-animations audit - #11246
Conversation
There was a problem hiding this comment.
looks good.
we can adopt the plural + variable pattern i linked above.
and also, as mentioned, let's add some relevant items to the fixture artifacts.json so we can see this in our samplejson report
a few nits but lgtm otherwise, so i'll approve a tad early.
| @@ -19,8 +19,11 @@ const UIStrings = { | |||
| =1 {# animated element found} | |||
There was a problem hiding this comment.
the comment says "the number of animations" but the text is number of elements. 🐱
i personally think it'd be better to report either count of noncomp animations or % of animations that were comped
There was a problem hiding this comment.
I fixed the comment, but I still think we should list the number of animated elements rather than the number of animations. We aren't listing the animations, only associating failure reasons with an animation name.
Animations can have more than one failure reason and animations with no name can have their failure reasons combined as duplicates. It would not always be clear where the animation count comes from, where the animated element count would be clear.
For example, this report could have an animation count of 4 if there are three unnamed animations all operating on the property height:
<div id="asdf" .... >
Unsupported CSS Property: height
Unsupported CSS Property: width myAnimation
There was a problem hiding this comment.
animations with no name can have their failure reasons combined as duplicates
ahhhhhhh
okay yeah that makes it tricky to summarize something that's intuitive. sg.
| @@ -19,8 +19,11 @@ const UIStrings = { | |||
| =1 {# animated element found} | |||
There was a problem hiding this comment.
animations with no name can have their failure reasons combined as duplicates
ahhhhhhh
okay yeah that makes it tricky to summarize something that's intuitive. sg.
Recent changes to chromium add the names of CSS properties which cannot be animated on the compositor to the DevTools trace. This PR adds those CSS property names to the "Unsupported CSS Property" failure reason in the report.
Chromium changes: https://chromium-review.googlesource.com/c/chromium/src/+/2320552
Issue: #2208