8000
Skip to content

new_audit: add minor aXe audits and re-weight existing ones #15298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jazyan merged 9 commits into from
Jul 26, 2023
Merged

new_audit: add minor aXe audits and re-weight existing ones #15298

jazyan merged 9 commits into from
Jul 26, 2023

Conversation

@jazyan
Copy link
Collaborator
@jazyan jazyan commented Jul 24, 2023 •
edited
Loading

This has the last few audits to include before LH 11.

Also checked through all the audits and updated their weightings accordingly based on the aXe 4.7 user impact.

  • Critical: 10
  • Serious: 7
  • Moderate: 3
  • Minor: 1

3 of the new audits in this PR (aria-allowed-role, image-redundant-alt, and table-duplicate-name) are minor.
Note that we previously didn't have minor impact audits.

@jazyan jazyan requested a review from a team as a code owner July 24, 2023 19:53
@jazyan jazyan requested review from connorjclark and removed request for a team July 24, 2023 19:53
@jazyan jazyan marked this pull request as draft July 24, 2023 19:53
@jazyan jazyan marked this pull request as ready for review July 25, 2023 19:23
@jazyan jazyan changed the title WIP: add remaining audits and reweight new_audit: add minor aXe audits and re-weight existing ones Jul 25, 2023
adamraine
adamraine reviewed Jul 25, 2023
View reviewed changes
cli/test/smokehouse/test-definitions/a11y.js Outdated
},
},
'skip-link': {
score: null,
Copy link
Contributor
@adamraine adamraine Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why couldn't this be tested? Is it because there is no main?

Copy link
Collaborator Author
@jazyan jazyan Jul 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it could be useful to know that having no skip link means this audit is not applicable rather than failed (which isn't obvious from the doc wording). But just updated this to have a test with a non-focusable skip link.

@jazyan jazyan merged commit d149e9c into main Jul 26, 2023
@jazyan jazyan deleted the a11y-weight branch July 26, 2023 15:43
@jazyan jazyan mentioned this pull request Aug 3, 2023
Merged
@connorjclark connorjclark mentioned this pull request Oct 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@connorjclark connorjclark Awaiting requested review from connorjclark connorjclark is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

1 more reviewer

@adamraine adamraine adamraine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@connorjclark connorjclark

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jazyan @adamraine @connorjclark @devtools-bot
0