8000
Skip to content

tests: add devtools test for important data warning - #11544

Merged
devtools-bot merged 2 commits into
masterfrom
add-web-test
Oct 14, 2020
Merged

tests: add devtools test for important data warning#11544
devtools-bot merged 2 commits into
masterfrom
add-web-test

Conversation

@adamraine
Copy link
Copy Markdown
Contributor

Imports devtools web test for the important data warning.

Devtools change: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2385182
Related #11438

@adamraine
adamraine requested a review from a team as a code owner October 9, 2020 22:12
@adamraine
adamraine requested review from connorjclark and removed request for a team October 9, 2020 22:13
@connorjclark connorjclark changed the title misc: add new web test for important data warning tests: add devtools test for important data warning Oct 9, 2020
@google-cla google-cla Bot added the cla: yes label Oct 9, 2020
@adamraine
Copy link
Copy Markdown
Contributor Author

How do we update the DT version cached in Github?

@connorjclark
Copy link
Copy Markdown
Collaborator

in devtools.yml, change lighthouse/lighthouse-core/test/chromium-web-tests/download-* to lighthouse/lighthouse-core/test/chromium-web-tests/ (or maybe lighthouse/lighthouse-core/test/chromium-web-tests/* idk)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0