E4CA
Skip to content

deps: upgrade puppeteer to 21.5.2 - #15645

Merged
connorjclark merged 1 commit into
mainfrom
pup-21-5-2
Nov 29, 2023
Merged

deps: upgrade puppeteer to 21.5.2#15645
connorjclark merged 1 commit into
mainfrom
pup-21-5-2

Conversation

@connorjclark
@connorjclark connorjclark commented Nov 29, 2023
Copy link
Copy Markdown
Collaborator

Resolves the errors we are getting in CI for ToT:

Lighthouse chrome popup
    1) "before all" hook for "should load without errors"
    2) "after all" hook for "should check the checkboxes based on settings"


  0 passing (24s)
  2 failing

  1) Lighthouse chrome popup
       "before all" hook for "should load without errors":
     Error: Navigating frame was detached
      at #onFrameDetached (file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/LifecycleWatcher.js:106:47)
      at file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/third_party/mitt/mitt.js:1:242
      at Array.map (<anonymous>)
      at Object.emit (file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/third_party/mitt/mitt.js:1:226)
      at CdpFrame.emit (file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/puppeteer/common/EventEmitter.js:85:23)
      at #removeFramesRecursively (file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:451:15)
      at #onClientDisconnect (file:///home/runner/work/lighthouse/lighthouse/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/FrameManager.js:99:42)

  2) Lighthouse chrome popup
       "after all" hook for "should check the checkboxes based on settings":
     Error: Timeout of 20000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (clients/test/extension/popup-test-pptr.js)
      at listOnTimeout (node:internal/timers:[56](https://github.com/GoogleChrome/lighthouse/actions/runs/7026262168/job/19118680276?pr=15638#step:11:57)9:17)
      at process.processTimers (node:internal/timers:512:7)

https://github.com/GoogleChrome/lighthouse/actions/runs/7026262168/job/19118680276?pr=15638

@connorjclark
deps: upgrade puppeteer to 21.5.2
< 7440 /batch-deferred-content>
cc4a302
@connorjclark
connorjclark requested a review from a team as a code owner November 29, 2023 21:49
@connorjclark
connorjclark requested review from adamraine and removed request for a team November 29, 2023 21:49
@connorjclark
connorjclark merged commit d4cd442 into main Nov 29, 2023
@connorjclark
connorjclark deleted the pup-21-5-2 branch November 29, 2023 22:38
@Genio40921 Genio40921 mentioned this pull request Nov 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamraine adamraine Awaiting requested review from adamraine adamraine is a code owner automatically assigned from GoogleChrome/lighthouse-hackers

Assignees

@adamraine adamraine

Labels

waiting4reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@connorjclark @adamraine @devtools-bot
0