feat: Add Naver List Import Feature (Combined with Google List Import)#495
feat: Add Naver List Import Feature (Combined with Google List Import)#495MarcoPNS wants to merge 4 commits intomauriceboe:devfrom
Conversation
Added Naver List Import in a similar style like the Google List Import. To keep the frontend clean I combined both list options.
|
Thanks for the PR! This is genuinely a nice addition! 🙌 One thing though: Korea is probably a bit too region-specific to be included by default. Could you convert it to an addon instead? That way users who want it can opt in. Also, we recently updated our contributing guidelines. Since your PR was already open before that, no worries for this one, but worth a read for future contributions: CONTRIBUTING.md |
|
@jubnl Hi! Thanks for your feedback. It's an addon now. I have also updated the branch to the latest dev branch version and resolved a conflict. |
f329dee to
6a63213
Compare
|
I made a mistake and included changes from the main branch that have not yet been included in the dev branch. I reverted this by force pushing. Hopefully, this PR is cleaner now. |
|
Branch updated again, resolved conflict ✅ |
- SSRF: validate user-supplied URLs with checkSsrf() before fetch in both importNaverList and importGoogleList; upgrade naver.me substring check to exact hostname comparison to prevent bypass - i18n: add missing places.importNaverList key to de.ts and es.ts - migration: switch Naver addon seed to INSERT OR IGNORE to preserve admin customizations on re-runs; restore budget_category_order CREATE TABLE to its original formatting - route: remove redundant cast after type-narrowing guard in naver-list handler - component: hoist provider ternary above try/catch in handleListImport - tests: add four new Naver import cases (502, empty list, no-coords, canonical URL skipping redirect fetch)
|
Closed in favor of #662 |
This PR adds a Naver List import feature, implemented in a similar style to the new Google List import. To maintain a clean frontend, both list import options are combined into a single modal. An API Key is not required.
Google Maps coverage in Korea is limited and many locations aren’t listed. Naver is widely used in Korea and provides better local spot coverage.
If the Naver import feature feels too specific, it could alternatively be provided as an addon.