fix(particle): handle floating-point precision in burst triggers - #19204
Open
ganjuwei wants to merge 1 commit into
Open
fix(particle): handle floating-point precision in burst triggers#19204ganjuwei wants to merge 1 commit into
ganjuwei wants to merge 1 commit into
Conversation
Particle Burst determines whether the current frame crosses a trigger point using floating-point time. Account for precision errors during the comparison. Reference: https://forum.cocos.org/t/topic/176928
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Code Size Check Report
Interface Check ReportThis pull request does not change any public interfaces ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Particle Burst determines whether the current frame crosses a trigger point using floating-point time. Account for precision errors during the comparison.
Reference: https://forum.cocos.org/t/topic/176928
Re: #
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: