ci: pilot V build cache in toml CI - #28041
Conversation
Pilot actions/cache@v4 for V binary with key v-toml-${{ runner.os }}-
hashFiles(cmd/**,vlib/**,thirdparty/**,make*,.github/actions/setup-v/**)
stacked before setup-v; restore-keys fallback. Limited to toml_ci.yml to
measure hit-rate before expanding. Refs vlang#27835, vlang#27844.
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d85e5fda2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Cache V build | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: v |
There was a problem hiding this comment.
In toml-module-pass-external-test-suites, every cache hit is immediately followed by the composite setup action, whose .github/actions/setup-v/action.yml lines 48–53 unconditionally run make. The GNUmakefile declares all phony and its recipe always bootstraps v1/v2 and overwrites ./v, so the restored binary cannot reduce build time and instead adds cache restore/save overhead. Gate the build on the cache-hit output, or cache build inputs that make can actually reuse.
Useful? React with 👍 / 👎.
Refs #27844. Part of #27835.
Pilot for #27844 — not closing yet (2B will expand after hit-rate).
What
actions/cache@v4forvbinary intoml_ci.ymlbeforesetup-v:path: v,key: v-toml-${{ runner.os }}-${{ hashFiles('cmd/**','vlib/**','thirdparty/**','make*','.github/actions/setup-v/**') }},restore-keys: v-toml-${{ runner.os }}-Why
.agents/plans/2026-08-06-v27835-remaining-plan.md§2A.Validation
ruby -ryaml YAML ok,setup-vstill runs (cache restore before build, no behavior change on miss).hashFilescovers V source that invalidates binary; stale binary risk is cache miss only.Risk
restore-keys, pilot only. Resolves CI: evaluate safe caching of V build artifacts #27844 after 2B if expanded.Stack
master). Tracked separately; will be rebased if needed.