Merged
Conversation
Detects a bare clone's worktree dir to make root more contextual
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sesh rootcommand to properly detect git worktrees from bare clones with.gitfolder conventiongitBareRootNamestrategy that returns the bare repo name plus the worktree directory (e.g.,myrepo/main)Problem
The
RootName()function only usedgit rev-parse --show-toplevel, which returns the worktree directory itself rather than the parent repository root for bare clone setups. This causedsesh rootto return just the worktree name (e.g.,main) instead of including the repo context.Solution
Created a new
gitBareRootNamestrategy innamer/root_git_bare.gothat:getBareWorktreePath()functionmyrepo/maininstead of justmainAdded this strategy as the first option in
RootName()so bare worktrees are detected before falling back to standard git detection.