8000
Skip to content

editor: fix some settings do not get applied automatically and need editor reload - #10266

Open
ammarahm-ed wants to merge 3 commits into
masterfrom
fix/editor-settings-apply
Open

editor: fix some settings do not get applied automatically and need editor reload#10266
ammarahm-ed wants to merge 3 commits into
masterfrom
fix/editor-settings-apply

Conversation

@ammarahm-ed
Copy link
Copy Markdown
Collaborator

Description

QA Scope

  1. Changing double spaced lines setting in Settings -> Editor should instantly work
  2. Changing date/time format should immediately reflect in the editor when using /date shortcuts
  3. on a fresh install markdown shortcuts should be disabled

Type of Change

  • Bug fix
  • Feature

Visuals

  • Attached relevant screenshots / screen recording / GIF
  • N/A (not a feature or no UI changes)

Testing

  • Ran all E2E tests
  • Ran all integration tests
  • Added/updated tests for this change (if needed)
  • N/A (tests not needed — explanation provided below)

If tests were not added, explain why

Platform

  • Web
  • Mobile
  • Desktop

Sign-off

  • QA passed
  • UI/UX passed

@github-actions
Copy link
Copy Markdown

Cloudflare Pages Preview

https://508aaf60.notesnook-app.pages.dev

Commit: ad0b8c4

@github-actions
Copy link
Copy Markdown

Desktop Previews

Commit: ad0b8c4

< C3D3 p class="ml-1 mb-2 mt-2" data-show-on-error hidden> Sorry, something went wrong.

@github-actions
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0