Fix invalid Python dev container image tag#180
Open
swankystark wants to merge 2 commits intogoogle-deepmind:mainfrom
Open
Fix invalid Python dev container image tag#180swankystark wants to merge 2 commits intogoogle-deepmind:mainfrom
swankystark wants to merge 2 commits intogoogle-deepmind:mainfrom
Conversation
- Changed image tag from 0-3.12 to 1-3.12 - The 0-3.12 tag does not exist in Microsoft's dev container registry - Version 1 with Python 3.12 (1-3.12) is the correct valid tag Fixes google-deepmind#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the invalid Python dev container image tag that was preventing the repository from being opened in a dev container.
Problem
The current dev container configuration uses an invalid image tag
mcr.microsoft.com/devcontainers/python:0-3.12that doesn't exist in Microsoft's container registry. The0-prefix versions only support up to Python 3.11.Solution
Updated the image tag to
mcr.microsoft.com/devcontainers/python:1-3.12, which is the correct valid tag for Python 3.12 with version 1 of the dev container images.Changes
.devcontainer/devcontainer.jsonimage from0-3.12to1-3.12Verification
Verified against the official Microsoft dev container registry that:
0-3.12does not exist1-3.12is a valid tagFixes Fix invalid Python dev container image tag #178