Fix Pytest Collection Failure in CI#224
Open
BeathovenGala wants to merge 3 commits intogoogle-deepmind:mainfrom
Open
Fix Pytest Collection Failure in CI#224BeathovenGala wants to merge 3 commits intogoogle-deepmind:mainfrom
BeathovenGala wants to merge 3 commits intogoogle-deepmind:mainfrom
Conversation
Switched to using ThreadPoolExecutor as a context manager to ensure proper shutdown even if exceptions occur during task submission.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where pytest fails to collect tests in the CI environment (GitHub Actions), resulting in "no tests ran" and exit code 5.
Fix: I updated
pyproject.tomlto explicitly define test discovery patterns (like *Test classes), ensuring pytest finds tests that were previously ignored in CI.This ensures that:
python_functions: Look for functions matching test_*.
Verification
Ran pytest --collect-only locally and confirmed that tests (awa
concordia/components/agent/agent_components_test.pyand egs) are immediately and correctly collected.