fix: keep INTELIS_TRACK across the sudo boundary - #113
Merged
Conversation
sudo runs with env_reset, so exporting INTELIS_TRACK and then running intelis update dropped it before root ever saw it. It failed silently, in the one direction that matters: an operator pinning a lab to master for a hotfix was told nothing and quietly got the latest release. intelis update now forwards it when set. The guide documented the variable without ever showing a working invocation, so it now shows one, and says why exporting alone is not enough. It also still described tagging by hand — that is composer publish now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sudo runs with env_reset, so exporting INTELIS_TRACK and then running
intelis update dropped it before root ever saw it. It failed silently,
in the one direction that matters: an operator pinning a lab to master
for a hotfix was told nothing and quietly got the latest release.
intelis update now forwards it when set. The guide documented the
variable without ever showing a working invocation, so it now shows one,
and says why exporting alone is not enough. It also still described
tagging by hand — that is composer publish now.