fix(sql): convert custom type values in kysely where clauses - #8189
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8189 +/- ##
========================================
Coverage 99.65% 99.65%
========================================
Files 287 287
Lines 30343 30386 +43
Branches 8026 8396 +370
========================================
+ Hits 30239 30282 +43
Misses 100 100
Partials 4 4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
convertValues: true, the kysely plugin converted custom type values ininsertInto().values()andupdateTable().set(), but not in where clauses. Passing a custom type's runtime value (e.g. a value object) to.where()failed when the driver tried to bind it, even though the types allow it.The transformer now converts comparison operands too: it resolves the entity property from the left operand (a plain or table-qualified column) and runs the right operand through the same conversion as insert/update values, including
convertToDatabaseValueSQLwrapping andinlists.Reproduction: https://github.com/mificot/kysely-cutom-types-where-clause