fix(client): enable HTTP/2 - #1735
Open
Marck wants to merge 1 commit into
Open
Conversation
net/http disables HTTP/2 when TLSClientConfig is set, so Gatus only ever speaks HTTP/1.1. HTTP/2-only endpoints answer 505 and the endpoint can never pass — Quad9's DoH is one example. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Author
|
@TwiN requesting your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net/http disables HTTP/2 when TLSClientConfig is set, so Gatus only ever speaks HTTP/1.1. HTTP/2-only endpoints answer 505 and the endpoint can never pass — a Quad9's DoH check is a example that fails with 505 errors.
no ForceAttemptHTTP2: 505 / connection reset
ForceAttemptHTTP2: HTTP/2.0 -> 200 OK
go test ./client/ passes.
You can test this check by configuring the following:
Checklist
README.md, if applicable.