fix: recompute axes grid bounds when switching files#2988
fix: recompute axes grid bounds when switching files#2988soumyasavarn wants to merge 14 commits intof3d-app:masterfrom
Conversation
GridAxesConfigured was not being reset when the importer changed (i.e. on file switch), so ConfigureGridAxesUsingCurrentActors() was never re-called. Add GridAxesConfigured = false alongside the existing GridConfigured = false in UpdateActors(). Fixes f3d-app#2963
|
\ci fast |
application/testing/tests.interaction.cmake
Outdated
Show resolved
Hide resolved
removed unnecessary comment Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
There was a problem hiding this comment.
hum, the result doesnt look right, the axes grid should be centered on the dragon.
There was a problem hiding this comment.
the feature doesnt seem to work yet.
8000 Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
|
@mwestphal I tested with the "F3D-3.4.1-147-g30c7f045-Windows-x86_64-raytracing":
My fix makes the grid reappear on switch, but the bounds show -58 to 100 |
This reverts commit 72d9140.
It looks like the bounds computation is not correct for some reason, so you need to dig into that. |
Please do not merge with master, but use rebase instead, and only when needed. |
…lity This ensures ConfigureColoringAndVisibilities() is called when switching files, correctly updating actor visibility for the new file. Without this, old file actors may remain visible, causing wrong bounds computation for the axes grid.
4398688 to
d3e2e36
Compare
Describe your changes
GridAxesConfiguredwas not being reset when the importer changed on file switch, soConfigureGridAxesUsingCurrentActors()was never re-called with the new file's bounds. Addedthis->GridAxesConfigured = false;alongside the existingthis->GridConfigured = false;inUpdateActors()invtkext/private/module/vtkF3DRenderer.cxx.Issue ticket number and link if any
Fixes #2963
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.