[Auth] Should not force App Check token refreshes#15716
Conversation
Fix bug introduced in Swift transition
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an inefficiency in how App Check tokens are handled. By changing forcingRefresh from true to false when calling getToken, the App Check SDK's caching mechanism will be utilized. This will prevent unnecessary token refreshes on every authentication request, leading to improved performance and reduced network overhead. The change is well-targeted and correct.
Fix #15372