fix(firestore): fetch large documents in chunks from local SQLite cache - #8362
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
📝 PRs merging into main branchOur main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released. |
…he (#8362) The SDK can store large documents in the cache, but it cannot read them back into memory because SQLite's `CursorWindow` has a 2MB row read limit. This change works around that limitation by reading large rows in chunks using `SUBSTR`. The goal is to support reading 16MB documents from the cache. Notes: - Reading a 16MB document with this takes ~250ms in my testing in the emulators, which is slow. - Does not impact latency for cache reads that are below 1MB - Alternatives considered: migrating to different SQLite library (high effort), read/write large documents directly in the filesystem (complex).
The SDK can store large documents in the cache, but it cannot read them back into memory because SQLite's
CursorWindowhas a 2MB row read limit. This change works around that limitation by reading large rows in chunks usingSUBSTR.The goal is to support reading 16MB documents from the cache.
Notes: