Firebase: Adjust undefined import causing IDE annoyances#2379
Firebase: Adjust undefined import causing IDE annoyances#2379Feiyang1 merged 2 commits intofirebase:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Thanks so much!
It probably doesn't make a huge difference, but I'd prefer to change the typing to
declare namespace empty {
}
export = empty;
Can you please also sign the CLA, so we can approve and merge the change?
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@Feiyang1 I agree on the typing, I changed it to an empty namespace per your comment. |
|
Looks good, Thanks! |
|
May I pretty please ask to get this published soon? It doesn't solve only the reported issue but for me, it's crashing tsserver and making Typescript experience very unpleasant. |
This change attempts to prevent the auto-importing of an exported
undefinedvalue fromfirebase/empty-import, which predominantly occurs in VS Code.Fixes #2203