Merged
Conversation
added 5 commits
October 20, 2023 10:30
added *pt* to sub headers added rounded borders to sub sections
added byline highlighting the maximum vector score possible darkened vector score color to highlight it added rounded corners to each section added hover state to buttons changed border-dotted to dashed
Contributor
Author
Owner
|
Okay I'll take a look @sandipkarmokar |
Sayvai
approved these changes
Oct 24, 2023
Contributor
There was a problem hiding this comment.
@sandipkarmokar - Nice work Sandi 😎
Managed to run the changes locally, and looks good. No real issues found 🔥
And just as importantly this time, the code changes in the PR are all actually scoped and highlights only the intended changes in the diffs (e.g. without any additional / unnecessary formatting changes), which makes reviewing actual changes easier on the eye for fellow reviewers.
Contributor
|
@srbhr Please remember to |
srbhr
approved these changes
Oct 25, 2023
bmck039
pushed a commit
to bmck039/Resume-Matcher
that referenced
this pull request
Jan 27, 2026
* changes made: added *pt* to sub headers added rounded borders to sub sections * Changes made added byline highlighting the maximum vector score possible darkened vector score color to highlight it added rounded corners to each section added hover state to buttons changed border-dotted to dashed * removed spaces from className typo * removed whitespace from className class * fixed changes which occured due to formatting issues --------- Co-authored-by: sandip <sandip@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes Made: