libcxathrow: Fix build on Musl - #177
Conversation
|
The primary author is a student in university as far as I know, so they have to take time away from open source activities parts of the year to focus on studies. In the meantime, |
msys2 is not actually musl, but thanks. will try later |
I'm not saying it is. I'm only claiming that both build failures (Musl and MSYS2) are caused by |
|
Ok, great there is another lsp for meson, so this repo will be archived |
Are you talking about |
|
Hey @meator I'm reviving mesonlsp. Thank you for your advices here, I will attempt to implement them |
I do not consider this change to be fully polished (but I left the code in a better state than it was in). I am open to discussion about the problematic of determining correct exception unwinding mechanism on different operating systems/libcs.
My intent is to package mesonlsp. To be honest, I expected a LSP for Meson to have a cleaner build process. This project depends on a lot of "throwaway forks" of popular libraries/projects with few custom commits added. As a package maintainer, I would prefer to see more robust solutions, and if they aren't feasible, I would like to see documented commitments to maintain these forks, to "backport" upstream updates and to release/tag versions every so often. The muon fork is especially discouraging. The current latest release is also not buildable (because it lacks 8edb5af).
But I understand that maintaining an open-source project is a difficult task (I have also noticed the call for maintainers). I intend my comments to be constructive criticism for areas which could be improved if the project wishes to spend its limited resources on improving the packaging experience.
To return to the focus of this PR, I would also like to note that the libunwind optional dependency should be documented somewhere. If I hadn't encountered issues with building mesonlsp on Musl which lead me to
src/libcxathrow/meson.build, I wouldn't have noticed this dependency and I would have packaged a version of mesonlsp which wouldn't print any useful stacktraces on Musl. If there is interest, I am willing to collaborate on improving this documentation (but mesonlsp currently doesn't have a dedicated place to document the build or packaging process, it has only a brief shell snippet in README).Checklist:
mesonlsp.spec,scripts/create_license_file.shand all GitHub Actions files?related to #174