Eljees · 2026-07-28T09:36:27Z

Description:

Newline matches contain both the newline byte offset and the first byte of the next line. The location calculation previously used the newline byte itself as the column offset, so matches after the first line were shifted one column to the right. This change tracks the actual line start separately while preserving the existing line-slice indexes.

The regression coverage now derives newline indexes from realistic LF and CRLF input, verifies identical matches on the first and later lines, and updates the affected expected coordinates for plain and decoded findings.

Tested with Go 1.24.11:

go test ./detect -run '^Test(GetLocation|Detect|FromGitStaged|FromFiles|DetectWithArchives|DetectRuleAllowlist)$' -count=1

Checklist:

Does your PR pass tests?
Have you written new tests for your changes?
Have you lint your code locally prior to submission?

Signed-off-by: Eljees <3.14hell@gmail.com>

Eljees · 2026-08-09T10:26:21Z

Ping on this one and #2219 - both open since 28 July with no review. #2215 is a column offset fix, #2219 narrows the hashicorp-tf-password rule; they are unrelated and can be taken separately.

Eljees · 2026-08-14T19:10:54Z

Following up on my ping of 9 August, with a correction to it: CI has not run on either PR. The Test workflow on both is at action_required and needs a maintainer to approve it, so there are no results to judge them by yet.

#2215 calculates columns from line starts rather than from the match offset; #2219 requires the identifier to end with the keyword in hashicorp-tf-password. Unrelated to each other.

fix: calculate columns from line starts

91293a1

Signed-off-by: Eljees <3.14hell@gmail.com>

Eljees requested review from bryanbeverly, dustin-decker, dxa4481 and zricethezav as code owners July 28, 2026 09:36

Navigation Menu

Uh oh!

Uh oh!

fix: calculate columns from line starts - #2215