Add dqlite developer documentation and improve dqlite related code comments#17105
Merged
tomponline merged 3 commits intocanonical:mainfrom Dec 2, 2025
Merged
Add dqlite developer documentation and improve dqlite related code comments#17105tomponline merged 3 commits intocanonical:mainfrom
tomponline merged 3 commits intocanonical:mainfrom
Conversation
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
8ad51d8 to
e4896fa
Compare
b2ae1c1 to
9439b32
Compare
minaelee
requested changes
Nov 28, 2025
27d82c2 to
b72c366
Compare
tomponline
reviewed
Dec 1, 2025
Member
There was a problem hiding this comment.
FWIW I think this is useful info to have in the LXD docs Internals section given that Dqlite is critical to LXD's operation and behaviour.
minaelee
reviewed
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Please consider if the suggested condensed changes would be sufficient, or if the detailed original version is preferred. I'll defer if the latter.
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
b72c366 to
426b9cb
Compare
Member
Author
Thanks for your review! I've addressed all comments. |
minaelee
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds dqlite developer documentation and comments to Raft and Cluster role constants. I'll continue improving upon the documentation/comments while working on cluster member evacuation improvements.