lxd/cluster/config: actually set a default expiry on remote token#17081
Merged
tomponline merged 4 commits intocanonical:mainfrom Nov 27, 2025
Merged
lxd/cluster/config: actually set a default expiry on remote token#17081tomponline merged 4 commits intocanonical:mainfrom
tomponline merged 4 commits intocanonical:mainfrom
Conversation
tomponline
previously approved these changes
Nov 26, 2025
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the core.remote_token_expiry configuration option was documented to have a default value of 15d but the default was not actually set in the code. The fix ensures that remote add tokens will expire after 15 days by default, matching the documented behavior.
- Adds
Default: "15d"to thecore.remote_token_expiryconfiguration schema entry
2e1d88a to
6b1a877
Compare
Fixes 82f1401 Reported-by: Thomas Parrott <thomas.parrott@canonical.com> Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
6b1a877 to
5d1ef3b
Compare
…kens Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…s of type string Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
552754b to
70d2110
Compare
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
70d2110 to
6a30932
Compare
Member
Author
|
Extracted from the GH runner logs: |
tomponline
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes 82f1401 part of #16595