Image export over devlxd for virtual machines#13878
Merged
tomponline merged 5 commits intocanonical:mainfrom Aug 6, 2024
Merged
Image export over devlxd for virtual machines#13878tomponline merged 5 commits intocanonical:mainfrom
tomponline merged 5 commits intocanonical:mainfrom
Conversation
Single letter or abbreviated variable names should only be used in small scopes and not in struct fields (see https://google.github.io/styleguide/go/decisions.html#single-letter-variable-names). Signed-off-by: Mark Laing <mark.laing@canonical.com>
Additionally, specify field names in hander structs. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
…for VMs. Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
|
Heads up @ru-fu - the "Documentation" label was applied to this issue. |
tomponline
approved these changes
Aug 5, 2024
Member
There was a problem hiding this comment.
LGTM thanks!
Please could we have an update to lxd-ci as well to catch regressions. Ta
Contributor
Author
Associated test PR: canonical/lxd-ci#255 |
tomponline
added a commit
that referenced
this pull request
Nov 11, 2024
#13878 Added `security.devlxd.images` for virtual machines but this key was not live-updatable. There was no particular reason for this. The endpoint is always available in the LXD agent and access is restricted by the host daemon. This PR allows the config key to be set while the instance is running. Closes #14206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an endpoint to the LXD agent
/dev/lxdsocket listener that proxies requests to/1.0/images/{fingerprint}/exporton the host LXD devlxd listener.Additionally cleans up
lxd-agent/devlxd.goand moves thesecurity.devlxd.imagesconfig key from the container specific config key map into the shared container/VM config key map and regenerates the metadata.I just worked on this to speed up my local test runs :)
Closes #12589