OVN tests for main test suite#14651
Merged
tomponline merged 7 commits intocanonical:mainfrom Dec 17, 2024
Merged
Conversation
simondeziel
reviewed
Dec 13, 2024
simondeziel
reviewed
Dec 13, 2024
Member
There was a problem hiding this comment.
Couldn't see it in action due to minor issues flagged by CodeQL but LGTM so far, thanks!
862c055 to
59ca184
Compare
Contributor
Author
|
@simondeziel just setting the northbound connection isn't enough. I've also set the certificates (based on a previous failed run). But now it fails with the following error: Not sure on next steps. |
simondeziel
reviewed
Dec 15, 2024
Member
There was a problem hiding this comment.
Love it but couldn't see it in action due to my protocol mistake (ssl:// vs ssl:).
Contributor
Author
Ahhh of course. I'll update the commit. Then I think I'll split up this PR because the formatting of |
59ca184 to
11e3af0
Compare
11e3af0 to
55978eb
Compare
simondeziel
reviewed
Dec 16, 2024
55978eb to
4879e0e
Compare
tomponline
added a commit
that referenced
this pull request
Dec 16, 2024
This allows specifying the output of `lxd sql` as `sql`, `csv`, `table`, `compact`, `json`, or `yaml`. The new `sql` format is added so that the column names are not auto-formatted (upper cased, replacing underscores with spaces). This is added to ease scripting in tests and is required for #14651.
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com> Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
simondeziel
reviewed
Dec 16, 2024
4879e0e to
9d2e6e6
Compare
Contributor
Author
|
@simondeziel strange failure now: https://github.com/canonical/lxd/actions/runs/12356855388/job/34484491302?pr=14651#step:13:45737 It seems the IPv6 address is already up in the instance when running in CI, but the test fails locally if this line is not present. |
markylaing
commented
Dec 16, 2024
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
Signed-off-by: Mark Laing <mark.laing@canonical.com>
9d2e6e6 to
4df816a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds OVN networking tests to the main suite. This is primarily to give faster feedback when driver changes are made. This initial PR just validates that the configuration is applied correctly to the ovn northbound database. The
LXD_OVN_NB_CONNECTIONenvironment variable must be set to run the tests. The tests will fail if there is any existing data in the northbound database. The test expects thatovn-nbctlis available on the PATH.