Simplify config validation#14559
Merged
tomponline merged 8 commits intocanonical:mainfrom Nov 29, 2024
Merged
Conversation
`validate.Optional()` checks if the provided value is not empty before calling the other validator. As such, `validate.Optional(validate.IsNotEmpty)` is conceptually the same as `validate.IsAny`. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
`validate.Optional()` checks if the provided value is not empty before calling the other validator. Since `validate.IsAny` accepts anything, using, `validate.Optional(validate.IsAny)` is conceptually the same as `validate.IsAny`. Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…h,data}` validation Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
…ix` validation Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
kadinsayani
previously approved these changes
Nov 29, 2024
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
kadinsayani
approved these changes
Nov 29, 2024
tomponline
approved these changes
Nov 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validate.Optional()checks if the provided value is not empty before calling the other validator.As such,
validate.Optional(validate.IsNotEmpty)is conceptually the same asvalidate.IsAny.Also, since
validate.IsAnyaccepts anything, using,validate.Optional(validate.IsAny)is conceptually the same asvalidate.IsAny.