API: Add scope to metadata configuration API#14530
Merged
tomponline merged 6 commits intocanonical:mainfrom Dec 2, 2024
Merged
API: Add scope to metadata configuration API#14530tomponline merged 6 commits intocanonical:mainfrom
scope to metadata configuration API#14530tomponline merged 6 commits intocanonical:mainfrom
Conversation
1b70509 to
7f42bed
Compare
Member
Author
791eff4 to
4869da3
Compare
scope to metadata configuration APIscope to metadata configuration API
scope to metadata configuration APIscope to metadata configuration API
markylaing
previously requested changes
Nov 27, 2024
Contributor
There was a problem hiding this comment.
We'll need @tomponline or @simondeziel to review the local/global-ness of the config keys but other than that I just have a couple of small nits :)
4869da3 to
fa1f4a3
Compare
simondeziel
reviewed
Nov 27, 2024
8a58825 to
c49b172
Compare
tomponline
reviewed
Nov 29, 2024
tomponline
reviewed
Nov 29, 2024
c49b172 to
8d6c853
Compare
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
Signed-off-by: Kadin Sayani <kadin.sayani@canonical.com>
8d6c853 to
e4c3f93
Compare
Member
|
@edlerd this will be in latest/edge soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #14125.
This PR adds
scopeto the metadata configuration API endpoint,/1.0/metadata/configuration.Summary of changes:
metadata_configuration_scope;Scopefield toMetadataConfigurationConfigKeystruct;scopeto metadata for member specific config keys inlxd/network/driver_{bridge/macvlan/physical/sriov}.go;