Remove python2 shebangs where appropriate#1692
Merged
Arusekk merged 2 commits intoGallopsled:devfrom Oct 5, 2020
Merged
Conversation
Contributor
Author
|
Hmm, the coveralls output seems to have suddenly started considering the scripts so the coverage delta is relatively large, but I think it's a false positive. I'm not sure what the PyLint errors are 😬 |
Member
|
Easy, the pylint errors are due to line number changes (the simple line diff is not so great), especially that your changes are near the beginning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1404
All non-scripts have had the shebang removed.
Other than the
pwnlib/commandlinedirectory, these scripts were found (so the shebang was not removed):The empty files mentioned in #1404 appear to be used.
__doc__files inshellcraftare used inpwntools/pwnlib/shellcraft/__init__.py
Line 37 in 45eb8bc
pwnlib/encoders/arm/alphanumeric/alphanumeric.pyis indirectly imported throughpwntools/pwnlib/encoders/__init__.py
Line 12 in 55dfe9b
This means the empty files were not removed.