Conversation
jj-devhub
suggested changes
Sep 24, 2025
Contributor
There was a problem hiding this comment.
Changes already made looks good but kindly look into the one review put
Comment on lines
-888
to
-900
| // Build a set of keys to include: each parent by id and by name (if known) | ||
| let mut include_keys: Vec<String> = Vec::new(); | ||
| if let Some(map) = id_name_obj { | ||
| for pid in &parent_ids { | ||
| include_keys.push(pid.clone()); | ||
| if let Some(name_val) = map.get(pid).and_then(|v| v.as_str()) { | ||
| include_keys.push(name_val.to_string()); | ||
| } | ||
| } | ||
| } else { | ||
| include_keys.extend(parent_ids.iter().cloned()); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
why removed? May impact into breaking change possibly
Contributor
Author
There was a problem hiding this comment.
This part only mutates include_keys which is never used after. No reading, no mutating, no reference creating. these are the only times the include_keys appear.
Contributor
There was a problem hiding this comment.
ok will need to reintroduce this with other related implementations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on d
2F58
eleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.