Fix type error when using content collection images after apng support - #17783
Merged
Conversation
`apng` was added to VALID_INPUT_FORMATS in #17774, but the ImageFunction type in content/config.ts was not updated to match, so passing an image from a collection schema to a component failed to type-check. Add a type test asserting the schema's format union matches ImageInputFormat, and widen the check workflow's path filter so changes under packages/astro/src and the shipped .d.ts files run the examples check before merge.
🦋 Changeset detectedLatest commit: 779b954 The changes in this PR will be included in the next version bump. This PR includes changesets to release 422 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
commented
Aug 21, 2026
| - ".github/workflows/check.yml" | ||
| - "scripts/smoke/check.js" | ||
| - "packages/astro/src/types/public/**" | ||
| - "packages/astro/src/**" |
Princesseuh
approved these changes
Aug 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
apngto the format union returned byimage(). Add.apngto supported image formats and TypeScript declarations #17774 addedapngtoVALID_INPUT_FORMATSbut not to the matchingImageFunctiontype, so images from a collection schema no longer type-check againstImageMetadata— this breaksastro checkonexamples/blog, andmainhas been red since it merged.Testing
image()schema'sformatmatchesImageInputFormat; it fails without the fix. This runs intest:types, which is why the drift is caught here rather than by widening theastro checkpath filter.Docs