Fix circular import in virtual:astro:routes causing "undefined is not a function" with server:defer + astro:i18n - #17787
Merged
Merged
Conversation
…from astro/app/manifest
1 task
🦋 Changeset detectedLatest commit: 19dc422 The changes in this PR will be included in the next version bump. This PR includes changesets to release 422 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will improve performance by 17.89%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | Build: hybrid site (static + server) |
1.7 s | 1.5 s | +17.89% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing factory/fix-17785 (19dc422) with main (aa33b44)1
Footnotes
matthewp
approved these changes
Aug 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be
306A
applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the import in the generated
virtual:astro:routesmodule from'astro/app'(the barrel export) to'astro/app/manifest'(the direct path), breaking a circular dependency that causeddeserializeRouteInfoto beundefinedat evaluation time.Root Cause
The
virtual:astro:routesmodule importeddeserializeRouteInfofrom theastro/appbarrel, which pulled inBaseApp→DefaultFetchHandler→ambient.ts→virtual:astro:manifest→virtual:astro:routes, creating a circular dependency. When this cycle was evaluated in the dev module runner,deserializeRouteInfowas uninitialized, causingserializedData.map(deserializeRouteInfo)to throw "undefined is not a function".This was introduced by #17636 (v7.2.3). The manifest plugin (
serialized.ts) already applied the same fix with an explanatory comment — this second occurrence invite-plugin-routes/index.tswas missed.Fix
Import
deserializeRouteInfofrom'astro/app/manifest'instead of'astro/app', consistent with the pattern already used inserialized.ts.Verification
Reporter @talensjr confirmed the fix on their local reproduction project. A unit test has been added in
packages/astro/test/units/routing/routes-virtual-module.test.ts.Closes #17785