Hide empty lines in room detail view#3943
Open
johannaengland wants to merge 2 commits intoUninett:masterfrom
Open
Hide empty lines in room detail view#3943johannaengland wants to merge 2 commits intoUninett:masterfrom
johannaengland wants to merge 2 commits intoUninett:masterfrom
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3943 +/- ##
=======================================
Coverage 63.98% 63.98%
=======================================
Files 627 627
Lines 46386 46386
Branches 43 43
=======================================
Hits 29680 29680
Misses 16696 16696
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simrayz
approved these changes
Mar 27, 2026
Contributor
There was a problem hiding this comment.
Nice, consistency go go 😄 I think putting aliases after description works well, as aliases are in a way just extra descriptors.
Contributor
Author
|
Waiting for a review from Mr. NAV @lunkwill42 as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3893.
I think we should hide the aliases if they are empty, since it is also done that way in the location detail view.
The room position can be discussed, but I think it simplifies the detail view.
Screenshots:
Before:
After:
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.