Improved collaborator code. - #4504
Merged
Merged
Conversation
Contributor
- Simplified code.
- Error reporting gives the domain of the missing collaborator.
- Migrated code to use f-formats.
* Simplified code. * Error reporting gives the domain of the missing collaborator. * Migrated code to use f-formats.
pascalfleury
approved these changes
Oct 7, 2025
| cls.createCollaborator(file_path) | ||
| log.info("Loaded %s collaborators" % len(cls.COLLABORATORS)) | ||
| num_collaborators = len(cls.COLLABORATORS) | ||
| log.info(f"Loaded {num_collaborators} collaborators") |
Contributor
There was a problem hiding this comment.
I think you can put entire expressions in the {}, so that it could be
log.info(f"Loaded {len(cls.COLLABORATORS)} collaborators")
| log.info("Loaded %s contributors" % len(cls.CONTRIBUTORS)) | ||
| cls.createContributor(row.val) | ||
| num_contributors = len(cls.CONTRIBUTORS) | ||
| log.info(f"Loaded {num_contributors} contributors") |
Contributor
There was a problem hiding this comment.
ditto with expressions in f-strings.
| def getAcknowledgements(self) -> typing.Sequence[str]: | ||
| if not self.aks: | ||
| self.aks = [] | ||
| aks = [] |
Contributor
There was a problem hiding this comment.
could we use acks that hurts less?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.