Make DonateAction a TransferAction instead of a TradeAction - #3338
Merged
Conversation
DonateAction is explicitly "without compensation", so I propose to make it a subclass of TransferAction instead. All the other TradeActions involve a swap of items or an intention of each party both giving something and receiving something in return. (In fact, in broader contexts, the concept of trade is intentionally separated from gifts and donations -- there's even a saying that "trade is the origin of most problems". :-) There are 3 properties of TradeAction that would be lost: price, priceCurrency, and priceSpecification. To include price, one might make the `object` property be a MonetaryValue or TypeAndQuantityNode -- and if there's already an `object` then that might be turned into an array. (I posit that it does not need priceSpecification.)
Contributor
Author
|
TipAction is another possible difference; it is done in return for good service so I could see an argument for it either way. I'll add that to this PR if that makes sense. |
|
This pull request is being nudged due to inactivity. |
Contributor
Author
|
Who can I pay to look at this? :-) |
MatthiasWiesmann
approved these changes
Jun 24, 2024
Contributor
|
Lgtm
…On Mon, 24 Jun 2024 at 14:48, Matthias Wiesmann ***@***.***> wrote:
Merged #3338 <#3338> into main.
—
Reply to this email directly, view it on GitHub
<#3338 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJSGMQLS76QQWJZOQ2IFTZJAPRTAVCNFSM6AAAAABJZ336CWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGI3DMNZWGM4TMOI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Contributor
Author
|
Thanks, @MatthiasWiesmann & @danbri ! 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DonateAction is explicitly "without compensation", so I propose to make it a subclass of TransferAction instead.
All the other TradeActions involve a swap of items or an intention of each party both giving something and receiving something in return. (In fact, in broader contexts, the concept of trade is intentionally separated from gifts and donations.)
There are 3 properties of TradeAction that would be lost: price, priceCurrency, and priceSpecification. To include price, one might make the(EDIT: added these as properties in a later commit.)objectproperty be a MonetaryValue or TypeAndQuantityNode -- and if there's already anobjectthen that might be turned into an array. (I posit that it does not need priceSpecification.)