8000
Skip to content

FedCM Object Token Enhancement - #771

Merged
npm1 merged 11 commits into
w3c-fedid:mainfrom
pottis:tokenSupportInJSON
Aug 13, 2025
Merged

FedCM Object Token Enhancement#771
npm1 merged 11 commits into
w3c-fedid:mainfrom
pottis:tokenSupportInJSON

Conversation

@pottis
@pottis pottis commented Aug 7, 2025
Copy link
Copy Markdown
Contributor

This change extends the FedCM API to allow IdPs to return structured objects directly as tokens.


Preview | Diff

Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
@pottis
pottis requested review from TallTed and npm1 August 8, 2025 11:28
@mooreds
mooreds commented Aug 8, 2025
Copy link
Copy Markdown

@hlflanagan @wseltzer should we have a discussion about this proposal? Has it already happened at a meeting I missed?

Comment thread spec/index.bs Outdated
Comment thread spec/index.bs
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
@npm1 npm1 left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Added some other comments besides what Christian mentioned. I still think this needs some work, mainly in simplifying it and making it more correct to what we want.

Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
@npm1
npm1 commented Aug 8, 2025
Copy link
Copy Markdown
Collaborator

@hlflanagan @wseltzer should we have a discussion about this proposal? Has it already happened at a meeting I missed?

This was last discussed here https://github.com/w3c-fedid/meetings/blob/main/2025/2025-07-29-FedCM-notes.md

@pottis
pottis requested review from cbiesinger and npm1 August 8, 2025 18:28
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
@pottis
pottis requested review from domfarolino and npm1 August 11, 2025 13:46
Comment thread spec/index.bs
</div>

<!-- ============================================================ -->
### Token Content Privacy ### {#token-content-privacy}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this section adds much value

@npm1 npm1 left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned, you need to modify some other algorithms. For example, the 'show a continuation dialog' says it returns a (string, string?). And 'resolve' needs to allow passing an arbitary token too, not just a string

@pottis
pottis requested a review from npm1 August 12, 2025 18:34
@npm1 npm1 left a comment
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change resolve too? It shows as DOMString token still.

@pottis
pottis requested a review from npm1 August 12, 2025 18:52
@pottis
pottis requested a review from aaronpk August 13, 2025 04:06
@npm1
npm1 merged commit 843eb51 into w3c-fedid:main Aug 13, 2025
2 checks passed
github-actions Bot added a commit that referenced this pull request Aug 13, 2025
SHA: 843eb51
Reason: push, by npm1

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions Bot added a commit to mattdanielbrown/WebID that referenced this pull request Aug 13, 2025
SHA: 843eb51
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0