fixed MPEG-PS (DVD)/av-lib and a hardcoded time_base#2058
fixed MPEG-PS (DVD)/av-lib and a hardcoded time_base#2058uknunknown wants to merge 1 commit intotvheadend:masterfrom
Conversation
- fixed MPEG-PS (DVD)/av-lib and a hardcoded time_base
- added a worst case fallback to (90000,1)
Summary of ChangesHello @uknunknown, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the handling of MPEG-PS (DVD) streams by integrating the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces fixes for MPEG-PS (DVD) muxing with libav. The changes include adding the mpeg2dvd muxer, setting appropriate bitrate and buffer size for MPEG-PS, fixing a hardcoded time_base, and skipping unnecessary bitstream filtering for MPEG-2 video streams. The changes appear correct and address the described issues. I have one suggestion to improve maintainability by replacing magic numbers with named constants.
| c->rc_max_rate = 9800000; | ||
| // Set the VBV buffer size (1.835 Mbps for DVD) | ||
| c->rc_buffer_size = 224*1024*8; |
There was a problem hiding this comment.
These hardcoded values for DVD video parameters (9800000 and 224*1024*8) are magic numbers. To improve code readability and maintainability, consider defining them as named constants with descriptive names (e.g., DVD_MAX_BITRATE, DVD_VBV_BUFFER_SIZE_BITS) at the top of the file or in a relevant header.
|
ad79691 to
13e6d0a
Compare
- fixed MPEG-PS (DVD)/av-lib and a hardcoded time_base - added a worst case fallback to (90000,1)
13e6d0a to
5ad27f1
Compare
|