E4BE
Skip to content
/ nng Public
  • Notifications You must be signed in to change notification settings
  • Fork 559
  • [codex] document listener start errors - #2256

    Merged
    gdamore merged 1 commit into
    mainfrom
    gdamore/fix-doc-bug-2168
    Jun 8, 2026
    Merged

    [codex] document listener start errors#2256
    gdamore merged 1 commit into
    mainfrom
    gdamore/fix-doc-bug-2168

    Conversation

    @gdamore
    @gdamore gdamore commented Jun 7, 2026
    Copy link
    Copy Markdown
    Contributor

    fixes #2168 nng_listener_start can return more errors

    Document that nng_listener_start can return NNG_EADDRINUSE when the listener address is already in use and NNG_EPERM when binding is denied.

    Validated with git diff --check.

    You agree that by submitting a PR, you have read and agreed to our contributing guidelines.

    Summary by CodeRabbit

    • Documentation
      • Updated nng_listener_start documentation to include additional error code information.

    @coderabbitai
    coderabbitai Bot commented Jun 7, 2026
    Copy link
    Copy Markdown

    Review Change Stack

    No actionable comments were generated in the recent review. πŸŽ‰

    ℹ️ Recent review info
    βš™οΈ Run configuration

    Configuration used: defaults

    Review profile: CHILL

    Plan: Pro

    Run ID: a86e6580-1a3c-48b3-aba1-6456596d8627

    πŸ“₯ Commits

    Reviewing files that changed from the base of the PR and between b8caf85 and 7c6a5e2.

    πŸ“’ Files selected for processing (1)
    • docs/man/nng_listener_start.3.adoc

    πŸ“ Walkthrough

    Walkthrough

    Updated the nng_listener_start(3) manual page to document three error codes (NNG_EADDRINUSE, NNG_ECLOSED, and NNG_EPERM) that the function can return when binding fails.

    Changes

    Error Documentation Update

    Layer / File(s) Summary
    Document additional listener errors
    docs/man/nng_listener_start.3.adoc
    The ERRORS section now lists NNG_EADDRINUSE (address already in use), NNG_ECLOSED (listener closed), and NNG_EPERM (permission denied when binding) with consistent formatting.

    Estimated code review effort

    🎯 2 (Simple) | ⏱️ ~8 minutes

    Poem

    🐰 A rabbit hops through error codes so fine,
    Documenting paths where functions align,
    EADDRINUSE, ECLOSED, and EPERM's song,
    Now listeners know what errors belong! πŸ‡

    πŸš₯ Pre-merge checks | βœ… 5
    βœ… Passed checks (5 passed)
    Check name Status Explanation
    Title check βœ… Passed The title '[codex] document listener start errors' clearly summarizes the main change: documentation updates for nng_listener_start error codes.
    Description check βœ… Passed The description follows the template format, includes a fixes reference (#2168), provides clear explanation of what was documented, and confirms validation.
    Linked Issues check βœ… Passed The pull request successfully documents the two error codes (NNG_EADDRINUSE and NNG_EPERM) that issue #2168 identified as missing from the nng_listener_start documentation.
    Out of Scope Changes check βœ… Passed All changes are focused on documenting additional error codes for nng_listener_start as specified in issue #2168; no extraneous modifications are present.
    Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

    ✏️ Tip: You can configure your own custom pre-merge checks in the settings.

    ✨ Finishing Touches
    πŸ§ͺ Generate unit tests (beta)
    • Create PR with unit tests
    • Commit unit tests in branch gdamore/fix-doc-bug-2168

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❀️ Share

    Comment @coderabbitai help to get the list of available commands and usage tips.

    @gdamore
    gdamore force-pushed the gdamore/fix-doc-bug-2168 branch from eafd6ab to 7c6a5e2 Compare June 7, 2026 23:09
    @gdamore
    gdamore marked this pull request as ready for review June 7, 2026 23:09
    @gdamore
    gdamore merged commit b345797 into main Jun 8, 2026
    2 checks passed
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    doc: nng_listener_start can return more errors

    1 participant

    0