Don't bind dnsmasq to loopback interface #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows to have multiple instances of dnsmasq running, or even other DNS servers like systemd-resolved further improvements: - don't set IP address again for smb server - remove IP address from interface once the script is done - fixed some shellcheck suggestions concerning quoting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits.
The first commit just fixes outdated information from
README.md.The second commit improves the
start-server.shscript.Most importantly,
dnsmasqno longer binds to the loopback interface, which allows multiple instances ofdnsmasqto coexist. And even other DNS servers like systemd-resolved, where I encountered the problem.(Now I'm wondering if DNS is necessary for this attack at all 🤔 If not, we could even do
--port=0to disable dnsmasq's DNS functionality and leave only DHCP and TFTP.)Furthermore, the script removes the IP address from the interface when done. And the IP address is only added in the
pxefunction, not also insmb.Let me know if you require any changes. :)
And thanks for this nice implementation again, even when it didn't work today in my case.