8000
Skip to content

fix: TypeError When Deleting Nested Data - #402

Open
zabakala wants to merge 1 commit into
mesqueeb:masterfrom
zabakala:delete-prop-fix
Open

fix: TypeError When Deleting Nested Data#402
zabakala wants to merge 1 commit into
mesqueeb:masterfrom
zabakala:delete-prop-fix

Conversation

@zabakala
Copy link
Copy Markdown

Hi. I just ran into an issue when trying to delete nested data.

vuex1
vuex2

Properly resolving the import from Firestore resolved the issue. Thx beforehand for taking a look at this PR.

@mesqueeb
Copy link
Copy Markdown
Owner

This is an issue when there are two different versions of firebase I believe.

1 similar comment
@mesqueeb
Copy link
Copy Markdown
Owner

This is an issue when there are two different versions of firebase I believe.

@zabakala
zabakala commented Apr 19, 2023
Copy link
Copy Markdown
Author

Yop, it could be. It is in line with the repo´s package.json, i.e. "firebase": "^9.0.0". In this particular erroneous case of mine, the imported one is firebase": "9.9.2", i.e. not 10 or onwards. But the imported /compat variant is to ensure correct functionality.

@zabakala
Copy link
Copy Markdown
Author

@mesqueeb Hi. Is there a probability of merging in either this one or anything else leading to the resolution of this reported issue? We have, for the time being, resorted to using a forked version of the repo with the fix included, but we would like to switch back to the original one.

@mesqueeb
Copy link
Copy Markdown
Owner

@zabakala I'm just not sure this is the correct fix. I'm dependency injecting the firebase instance IIRC. So there must be something going wrong somewhere else perhaps. I will try and have a look this week.

@mesqueeb
mesqueeb commented Jan 9, 2025
Copy link
Copy Markdown
Owner

@zabakala can you try with v2.0 which is now compatible with vue3 and firebase v9.0 compat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0