8000
Skip to content

net/url: Adds patch-pure-port and patch-impure-port #2464

Open
DarrenN wants to merge 3 commits intoracket:masterfrom
DarrenN:dn-patch-impure-port
Open

net/url: Adds patch-pure-port and patch-impure-port #2464
DarrenN wants to merge 3 commits intoracket:masterfrom
DarrenN:dn-patch-impure-port

Conversation

@DarrenN
Copy link
Copy Markdown
Contributor
@DarrenN DarrenN commented Feb 9, 2019

Background

net/url was missing functions to make HTTP requests with the PATCH verb. API endpoints accepting PATCH are becoming more common.

This PR adds patch-pure-port and patch-impure-port.

@DarrenN
Copy link
Copy Markdown
Contributor Author
DarrenN commented Feb 11, 2019

Hmmm the two fails seem to be from an unrelated package? https://travis-ci.org/racket/racket/jobs/491101788#L2808

@jeapostrophe
Copy link
Copy Markdown
Collaborator

Hi and thanks for the patch. As @greghendershott mentioned on Slack, net/url should really be seen as a legacy library. Rather than adding a PATCH method, I'd rather expose the generic one with a better name so that changes like this are not needed in the future.

@DarrenN
Copy link
Copy Markdown
Contributor Author
DarrenN commented Feb 12, 2019

@jeapostrophe do you think there would be value in marking this library as deprecated in the documentation?

@jeapostrophe
Copy link
Copy Markdown
Collaborator

Sure

@greghendershott
Copy link
Copy Markdown
Contributor

In my experience with Racket, it's very rare for things to be marked as "deprecated" in the sense of "We want to remove X and break working applications, because reasons. We hope doing something rude will seem less rude if we do it slowly." πŸ˜„

So I think the most helpful thing would be a @margin-note near the top of net/url explaining that http-client is recommended for new applications, and any changes to net/url would be just bug fixes.

At least, that's my $0.02, but I'm not on the hook to maintain net/url (just some libs and pkgs that still use it).

@jeapostrophe
Copy link
Copy Markdown
Collaborator

I was thinking of a note like the one for net/cookies

https://docs.racket-lang.org/net/cookie.html

sorawee added a commit to sorawee/racket that referenced this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0