Fix WorkerManager.kill on Windows#3077
Merged
ahopkins merged 3 commits intosanic-org:mainfrom Nov 30, 2025
Merged
Conversation
ahopkins
approved these changes
Nov 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WorkerManager.killwas attempting to kill processes withos.killpg. This isn't available on Windows so there was a traceback every time it was called. I tried just falling back to theos.kill(process.pid, SIGKILL)but even with that it was timing out waiting for the worker process to end. Changing the signal to CTRL_C_EVENT worked though.fix #3043