[java] Leftovers about Dimensionable & type annotations#2203
Merged
oowekyala merged 5 commits intopmd:java-grammarfrom Jan 16, 2020
Merged
[java] Leftovers about Dimensionable & type annotations#2203oowekyala merged 5 commits intopmd:java-grammarfrom
oowekyala merged 5 commits intopmd:java-grammarfrom
Conversation
* Remove `Dimensionable`, remove its methods from the former implementations (except from ASTArrayDimsAndInits, which is itself deprecated) * The varargs ellipsis is now represented as an ArrayTypeDim. * This affects FormalParameter and LambdaParameter Closes pmd#997. All forms of type annotations are now supported.
Generated by 🚫 Danger |
This was referenced Jan 16, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ArrayDimensions node is now used as a child of MethodDeclaration and VariableDeclaratorId to represent extra dimensions
Remove
Dimensionable, remove its methods from the former implementations (except from ASTArrayDimsAndInits, which is itself deprecated)FieldDeclaration is not a TypeNode anymore. This fixes [java] AST inconsistency between primitive and reference type arrays #910
Brush up API of those nodes which declare a variable (we had getVariableDeclaratorId, getId, getVariableId, etc) -> now getVarId for everyone
The varargs ellipsis is now represented as an ArrayTypeDim.
int... isis parsed asint @A ... is, where the annotations are part of theArrayTypeDim, just as if the parameter was declaredint @A [] is.With that we can close #997: all forms of type annotations are supported and tested.