fix file_exists relative path bug #7932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwbmmm
reviewed
Aug 2, 2017
| return -1; | ||
| } | ||
| } | ||
| return ::access(File::TranslatePathWithFileCache(path).data(), mode); |
Contributor
There was a problem hiding this comment.
I think this change will disable the StaticFileCache feature.
The cause of this bug is that FileUtil::canonicalize is used in File::TranslatePathWithFileCache and File::TranslatePathKeepRelative. So what's the purpose of FileUtil::canonicalize? It a path is canonicalized, the access() result may be different.
Contributor
Author
There was a problem hiding this comment.
I think FileCache has no meaning, please see the code (File: TranslatePathWithFileCache),the logic is :
!translated.empty() && access(translated.data(), F_OK) < 0 && StaticContentCache::TheFileCache
so the physical file does not exist, and then the file cache won't exist.
I don't think this code is meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a.txt real location is a/a.txt
file_exists("a/b/../a.txt");
this code return value is false ,but hhvm process relative path,so this result is true,diff php,and then old way process relative path performance have problem,this modify way performance is improve 40%
replay case:
#3148