8000
Skip to content

Faster CI sun_tools test suite - #196

Merged
icy merged 3 commits into
icy:ngfrom
mondeja:faster-ci-sun_tools
Jul 13, 2021
Merged

Faster CI sun_tools test suite#196
icy merged 3 commits into
icy:ngfrom
mondeja:faster-ci-sun_tools

Conversation

@mondeja
@mondeja mondeja commented Jul 13, 2021 •
edited
Loading
Copy link
Copy Markdown
Collaborator

Replaces current CI sun_tools test suite virtual machine creation system with mondeja/solaris-vm-action. The performance increase is sill improvable, but now takes ~9 min against previous ~16 min.

@mondeja
mondeja force-pushed the faster-ci-sun_tools branch from 06a3601 to 4d22e66 Compare July 13, 2021 14:40
icy
icy approved these changes Jul 13, 2021
View reviewed changes
@icy icy left a comment
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change , but it's a lot of hard work. much appreciated!

@mondeja
mondeja force-pushed the faster-ci-sun_tools branch from 04d4a3e to 3e2828a Compare July 13, 2021 16:54
@mondeja
mondeja force-pushed the faster-ci-sun_tools branch from 3e2828a to b87ae0f Compare July 13, 2021 17:08
@mondeja
mondeja commented Jul 13, 2021
Copy link
Copy Markdown
Collaborator Author

It seems that caching the OVA file is even faster than pkgng test suite (6m 6s and 5m 12s) 🎉

I think that is ready, further improvements can be made in the action.

@mondeja
mondeja marked this pull request as ready for review July 13, 2021 17:17
@icy
icy commented Jul 13, 2021
Copy link
Copy Markdown
Owner

It seems that caching the OVA file is even faster than pkgng test suite (6m 6s and 5m 12s) tada

I think that is ready, further improvements can be made in the action.

That's very impressive!. Congrats!

@icy
icy merged commit 4ad6c45 into icy:ng Jul 13, 2021
@icy
icy commented Jul 13, 2021
Copy link
Copy Markdown
Owner
B270

@mondeja I've seen in recent merge events, that MacOS runners are not available! This is quite reasonable :( When that happens, there is not ETA, tests can take any undetermined time. I'd suggest you not to focus too much on the action improvements.

@icy
icy commented Jul 13, 2021
Copy link
Copy Markdown
Owner

See them here: https://github.com/icy/pacapt/actions/runs/1027708431

@mondeja
mondeja deleted the faster-ci-sun_tools branch July 13, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icy icy icy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mondeja @icy
0