8000
Skip to content

Add FreeBSD's pkgng support. - #25

Closed
sugar700 wants to merge 2 commits into
icy:masterfrom
sugar700:freebsd
Closed

Add FreeBSD's pkgng support.#25
sugar700 wants to merge 2 commits into
icy:masterfrom
sugar700:freebsd

Conversation

@sugar700
@sugar700 sugar700 commented Dec 8, 2013
Copy link
Copy Markdown

I decided to create a support for FreeBSD, just because pkgng is great. Requires bash package to be installed (it isn't by default in FreeBSD). The reason why /usr/bin/env bash is used is that FreeBSD uses /usr/local/bin/bash.

@icy
icy commented Dec 9, 2013
Copy link
Copy Markdown
Owner

Thank you very much @glitchmr . FreeBSD cool:) it's great to have pkgng support in pacapt

I'm working on this pull request. I will keep you posted.

@ghost ghost assigned icy Dec 9, 2013
@icy
icy commented Dec 11, 2013
Copy link
Copy Markdown
Owner

Hi @glitchmr ,

Here are some comments would you mind taking a look?

  1. The documentation would be updated in the script, not directly in README.md file. This is because README.md is generated (to help Github). Please check the function _help().
  2. The function _exec_ was updated to support install for FreeBSD's pkg. However, this only happens once for the Synchornization operation. I think it's better to add a trick (e.g, on the line 687) instead of changing the function _exec_ that would alter on all distributions. This is because I really want to use $@ expansion feature, not $* feature (that may be a different in any future use.)
  3. Is there any better way to detect if FreeBSD is being used? It's good to use /usr/sbin/pkg; it just wonder if there is more robust way.

Thanks again for your work.

@sugar700
sugar700 commented Dec 11, 2013
Copy link
Copy Markdown
Author

uname -a | grep -q FreeBSD could work, but I'm not sure about running unrelated programs. There is no /etc/issue.

@NgoHuy
NgoHuy commented Apr 18, 2014
Copy link
Copy Markdown
Collaborator

@xfix , Do you have /etc/os-release ? I saw that we can replace /etc/issue with /etc/*-release

@icy
icy commented May 4, 2014
Copy link
Copy Markdown
Owner

On May 4th, 2014, the master branch is closed. The script is written in a new way, and can be found on the ng branch. This pull request will not be merged. However, I keep it open, because we will find a way to integrate the function into the ng branch (by creating new library file lib/pkgng.sh)

icy added a commit that referenced this pull request May 5, 2014
@icy
Use :env to execute :bash. See also #25
fef4d58
icy added a commit that referenced this pull request May 5, 2014
@icy
lib/pkgng: FreeBSD support, thanks to Konrad Borowski. Close #25
0ac4acc
@icy
icy commented May 5, 2014
Copy link
Copy Markdown
Owner

Feature implemented in
8B7E

@icy icy closed this May 5, 2014
@icy icy added this to the Old stable milestone Jun 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@icy icy

Labels

None yet

Projects

None yet

Milestone

Old stable code (master branch)

Development

Successfully merging this pull request may close these issues.

3 participants

@sugar700 @icy @NgoHuy
0